Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Schirrmeister2017 RawEDF not preloaded #289

Closed
PierreGtch opened this issue May 5, 2022 · 1 comment · Fixed by #290
Closed

[bug] Schirrmeister2017 RawEDF not preloaded #289

PierreGtch opened this issue May 5, 2022 · 1 comment · Fixed by #290
Labels
bug

Comments

@PierreGtch
Copy link
Collaborator

Hi,
Since commit 2c05b9b, there is an error when loading Schirrmeister2017 :

RuntimeError: By default, MNE does not load data into main memory to conserve resources. inst.filter requires raw data to be loaded. Use preload=True (or string) in the constructor or raw.load_data().

But it should be fixed by adding the argument preload=True to the line:

moabb/moabb/datasets/schirrmeister2017.py

Line 85 in d4305c4

mne.io.read_raw_edf(path, infer_types=True)

@sylvchev
Copy link
Member

sylvchev commented May 6, 2022

Hi, thanks for reporting it. I'll make some local test to confirm this. Could you prepare a PR to make the changes?

@sylvchev sylvchev added the bug label May 6, 2022
PierreGtch added a commit to PierreGtch/moabb that referenced this issue May 9, 2022
@PierreGtch
preload Schirrmsister2017 - Fixes NeuroTechX#289
333925c
@PierreGtch PierreGtch mentioned this issue May 9, 2022
Merged
sylvchev pushed a commit that referenced this issue May 18, 2022
@PierreGtch
preload Schirrmsister2017 - Fixes #289 (#290)
87b3118 
* preload Schirrmsister2017 - Fixes #289

* Implements comment

* Update whats_new.rst

Co-authored-by: Pierre Guetschel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

preload Schirrmsister2017 - Fixes #289 PierreGtch/moabb
2 participants
@sylvchev @PierreGtch