Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BNCI2014009 scaling issues? #275

Closed
jsosulski opened this issue Mar 4, 2022 · 1 comment · Fixed by #318
Closed

BNCI2014009 scaling issues? #275

jsosulski opened this issue Mar 4, 2022 · 1 comment · Fixed by #318
Labels
dataset Supporting new dataset enhancement help wanted

Comments

@jsosulski
Copy link
Collaborator

The overall shape of the ERPs for Target / NonTarget seem to be plausible for this dataset. However, the absolute scalings appear to be off.

grafik

Intuitively, I would guess its off by a factor of 10, but I do not know exactly. This does not matter for most classifiers, but can impact preprocessing, e.g. when you reject epochs where minmax exceeds 100 muV or so.
@sylvchev
Copy link
Member

I think it is ok for most classifiers. Did you see any bad scaling factor in the code?

sylvchev pushed a commit to sylvchev/moabb that referenced this issue Jan 3, 2023
fix issue NeuroTechX#275
d985199
@sylvchev sylvchev mentioned this issue Jan 3, 2023
Merged
@sylvchev sylvchev linked a pull request Jan 4, 2023 that will close this issue
Fix dataset downloading errors #318
Merged
sylvchev added a commit that referenced this issue Jan 4, 2023
@sylvchev
Fix dataset downloading errors (#318)
4a418aa 
* fix Huebner zip error

* add whats new

* use pathlib and fix issue in script

* fix issue #275

* switch to pathlib and correct Windows path issue #300

Co-authored-by: Sylvain Chevallier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dataset Supporting new dataset enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dataset downloading errors sylvchev/moabb
2 participants
@jsosulski @sylvchev