[DRAFT] [WIP] Feat: share text to KISS #2111
Closed
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add intent filter for showing KISS launcher in Sharesheets from other apps or from context menu sharing
if text is not empty, then paste it to the search bar, else, show toast message saying it's empty
TBog
added a commit
to TBog/TBLauncher
that referenced
this pull request
Apr 25, 2024
cherrypicked from Neamar/KISS#2111
marunjar
requested changes
May 12, 2024
There was a problem hiding this comment.
@ram-a-dhan from my point of view this is almost fine. Can you please check comments for needed changes?
Also there are some merge conflicts which needs to be resolved before this can be merged.
|
This PR is inactive because it has been open 60 days with no activity. |
github-actions
bot
added
the
inactive
|
@ram-a-dhan can you please check merge conflicts in translation? |
|
This PR is inactive because it has been open 60 days with no activity. |
github-actions
bot
added
the
inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: New feature proposal for sharing text from anywhere into KISS search bar for quicker searching experience
General Idea
This is a WIP proposal to streamline the user experience of searching using KISS launcher. It works by sharing texts
(or web links) from almost anywhere on the phone into the KISS launcher's search bar via android's Sharesheet.
Background
I can't say for sure that i can speak for every user, but based on my experience in using KISS for almost every web (or play store, google maps location, local e-commerce, etc) search, i always find it a bit tedious and too repetitive to highlight the text i want, tap the "Copy" option, open KISS, long-tap KISS search input, and finally tap the "Paste" option before picking the search engine i want to search it with.
Why not just use the "Web Search" option in the highlighted text's context menu?
The "Web Search" option only uses the default search engine of the current browser i'm using. And when outside of browser environment, i only get the "Google App" option, which is frustrating to say the least. For context, i frequently jump between search engines and also between browsers. I have more than 3 search engines that i use daily for cross-referencing sources and comparing SEO results. I have more than 2 browsers for different needs (i have not set a default browser so i can always pick whichever i want everytime i search) as i don't want to mix up the browsing history (e.g. personal searches, workplace searches, people borrowing my phone for quick searches, etc).
Why not use DuckDuckGo's Bangs?
DDG's Bangs requires inclusion of pre-determined non-customizable prefix text to the search keyword, which would mean more hoops to jump through than i currently have to do. Besides , this problem is already solved by KISS launcher's list of search provider. The fewer steps one has to make the better and KISS launcher is already a huge step in the right direction, just needs one more :)
What changes code-wise?
AndroidManifest.xml: addedintent-filterfor registering KISS launcher as a sharing option in context menus.MainActivity.java: added handler insideonCreatefor the receivedIntent.EXTRA_TEXTand setting the text value ofsearchEditTextwith it; complete with error toast fallback.strings.xml (EN)+strings-.xml (IN): added error message text and 1 translation for my native language (the correct country code isIDand notINbtw :P ).Have you tested it yourself? Where are the screenshots?
I haven't. That's why this PR is labeled as [DRAFT] [WIP]. I don't have access to a powerful enough machine to run Android Studio to build and test it myself for now. I even made these proposed changes directly from this website 🤪 . I am still going to finish this PR, just not now. If anybody is also interested in this proposed feature and DO can build and test it as soon as it takes, please do share the results here. 🙇
So what now?
I will build and test it myself when i have a suitable hardware for it. No exact time that i can tell, but i will commit to this, because i need this, except if this PR is deemed unsuitable by the maintainers. Then i would (probably) keep this fork a little longer. In the meantime i accept reviews, critiques, and suggestions. I will do as best as i can to get this PR acceptable.
Terima kasih atas perhatian dan pertimbangannya
Matur nuwun 🙏