Add DRA driver For IMEX #1195
Draft
Add DRA driver For IMEX #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Desiniotis <[email protected]>
Signed-off-by: Christopher Desiniotis <[email protected]>
tariq1890
reviewed
Jan 7, 2025
| imagePullSecrets: {{ toYaml .Values.draDriver.imagePullSecrets | nindent 6 }} | ||
| {{- end }} | ||
| {{- if .Values.draDriver.deviceClasses }} | ||
| deviceClasses: {{ toYaml .Values.draDriver.imagePullSecrets | nindent 6 }} |
There was a problem hiding this comment.
Suggested change
| deviceClasses: {{ toYaml .Values.draDriver.imagePullSecrets | nindent 6 }} | |
| deviceClasses: {{ toYaml .Values.draDriver.deviceClasses | nindent 6 }} |
| @@ -841,6 +843,45 @@ type SandboxDevicePluginSpec struct { | |||
| Env []EnvVar `json:"env,omitempty"` | |||
| } | |||
|
|
|||
| // DRADriverSpec defines the properties for the NVIDIA DRA Driver deployment | |||
| type DRADriverSpec struct { | |||
| // Enabled indicates if the deployment of NVIDIA DRA Driver through the operator is enabled | |||
There was a problem hiding this comment.
Let's use the full-form of DRA when mentioning it first, and then use the acronyms everywhere else
Comment on lines
+149
to
+150
| - "" | ||
| - apps |
There was a problem hiding this comment.
We probably don't need these two. The current permissions for the "apps" and "" (core) api groups which are already specified in this doc should suffice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.