Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Root folders for older persistence stores #153

Merged
merged 7 commits into from
Mar 6, 2024

Conversation

jvigliotta
Copy link
Collaborator

Closes #102

Fixes a situation created in older persistence stores where a root (ex: shared) folder was created, but a domain object was not created with it. Now, we check if a root folder has a domain object, if not then it's an empty folder. We're keeping the functionality of creating missing user folders as well, this is just a modification that allows the same thing to be done for shared folders.

@jvigliotta jvigliotta requested a review from davetsay February 22, 2024 22:23
Copy link
Collaborator

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davetsay davetsay merged commit b654e8b into main Mar 6, 2024
2 checks passed
@davetsay davetsay deleted the empty-shared-folders branch March 6, 2024 00:07
@mudinthewater
Copy link
Contributor

LOL I was just trying to figure out why this was happening to me still on a newer build. Turns out it just wasn't fixed yet. Back to seeding root objects I go!

@jvigliotta
Copy link
Collaborator Author

LOL I was just trying to figure out why this was happening to me still on a newer build. Turns out it just wasn't fixed yet. Back to seeding root objects I go!

Yeah this one slipped by me... should be good in this new build though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create roots for shared spaces if they don't exist
3 participants