Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run backend e2e tests with given gateway docker tag when provided in PR body, add dev docs #1624

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

dandelany
Copy link
Collaborator

@dandelany dandelany commented Jan 3, 2025

___REQUIRES_GATEWAY_PR___="116"

Description

Closes #1538

For reference see NASA-AMMOS/aerie-ui#1439

This PR contains two things:

Verification

I tested this PR both with and without the REQUIRES_GATEWAY_PR tag at the top, and verified that when it is present, the e2e test action correctly pulls and runs the gateway image tagged as pr-116 (shown in the workflow run logs)

@Mythicaeda
Copy link
Contributor

Mythicaeda commented Jan 3, 2025

I'd recommend using ___REQUIRES_GATEWAY_PR___="119" instead, as that contains no behavior changes to the Gateway code.

Ah, I see why you're using 116, since it's already publishing an image.

@dandelany dandelany merged commit e92f98a into develop Jan 3, 2025
14 checks passed
@dandelany dandelany deleted the dev/gh-test-workflows branch January 3, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process + workflows for testing UI PRs against specified backend branch
2 participants