Adds "HASURA_API_URL" to docker-compose #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explicitly adds the
HASURA_API_URLto our docker-composes. The value used is the default value, so there is no behavior change.This change should mitigate the usability issue brought up in #1619, where it wasn't clear that
GQL_API_URLandHASURA_API_URLwere separate envvars that both need to be configured.Verification
No verification was done, as there is no behavior change, just explicitly setting an envvar to its default value.
Documentation
Improved the wording of this envvar in the Gateway docs.