Make generic Groth16 implementation #758
Conversation
jonas-lj
force-pushed
the
jonas/clean_up_groth16
branch
from
4ffcca8 to
3d538bd
Compare
| )?; | ||
| i += G2_SIZE; | ||
|
|
||
| let n = u64::from_le_bytes( |
There was a problem hiding this comment.
should we verify that n>0?
There was a problem hiding this comment.
let's double check that this is backward compatible
There was a problem hiding this comment.
That's checked in test_prepare_pvk_bytes in api_tests.rs.
| pub(crate) mod generic_api; | ||
|
|
||
| #[derive(Debug, Deserialize)] | ||
| pub struct Proof<G1: Pairing> |
There was a problem hiding this comment.
while it's ok to how we use it today, isn't in general this is symmetric in the sense that a proof can be G2, G1, G2, where pairing is a trait of G1?
There was a problem hiding this comment.
I'm not sure I follow. You'd prefer a proof to be (G1, G2, G1) because it's smaller, assuming that we've always put G1 to be the smallest, right? But yes, the pairing is symmetric, so there's nothing stopping us from implementing Pairing as a trait for G1::Other for all G1: Pairing.
jonas-lj
force-pushed
the
jonas/clean_up_groth16
branch
from
b03b8c1 to
ed4cd5c
Compare
| )?; | ||
| i += G2_SIZE; | ||
|
|
||
| let n = u64::from_le_bytes( |
There was a problem hiding this comment.
let's double check that this is backward compatible
Added in #772. |
jonas-lj
force-pushed
the
jonas/clean_up_groth16
branch
from
77199dd to
caeda1a
Compare
This PR replaces the BLS12-381 Groth16 implementation with a generic implementation that uses the
GroupElementandPairingabstractions. This is much simpler and wraps calls to external libraries.We can also use this for the BN254 Groth16 implementation, but it requires that we first add the BN254 construction to the supported groups.
Benchmarks have demonstrated, that the performance is unchanged.