feat: pickup and drop off window validator #1935
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 24, 2024
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 587efd4 📊 Notices ComparisonNew Errors (2 out of 1788 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1788 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1788 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1788 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1788 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
davidgamez
approved these changes
Jan 6, 2025
| } | ||
|
|
||
| @Override | ||
| public boolean shouldCallValidate(ColumnInspector header) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
forbidden_arrival_or_departure_time: Triggers when both arrival/departure times and pickup/drop-off windows are defined, which is not allowed.missing_pickup_or_drop_off_window: Identifies cases where either the start or end pickup/drop-off window is missing but the other is present.invalid_pickup_drop_off_window: Flags scenarios where the end pickup/drop-off window occurs before or at the same time as the start window.Expected behavior:
forbidden_arrival_or_departure_time: This example showcases the dynamic display of columns (thedeparture_timecolumn is missing from display as it is not defined in the tested feed)missing_pickup_or_drop_off_window:invalid_pickup_drop_off_window:Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything