Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Corrected typos in Features.md #1728

Closed
wants to merge 5 commits into from
Closed

chore: Corrected typos in Features.md #1728

wants to merge 5 commits into from

Conversation

jcpitre
Copy link
Contributor

@jcpitre jcpitre commented Mar 24, 2024 •
edited
Loading

The FEATURES.md file contained Bike Allowed whereas the right string is Bikes Allowance
Other typos related to uppercase - lowercase confusion
In-station traversal time replaced by Traversal Time

@jcpitre jcpitre changed the title chore: Replaced the wrong Bike Allowed by Bike Allowance chore: Replaced the wrong Bike Allowed by Bike Allowance in Features.md Mar 24, 2024
@jcpitre jcpitre changed the title chore: Replaced the wrong Bike Allowed by Bike Allowance in Features.md chore: Replaced the wrong "Bike Allowed" by "Bike Allowance" in Features.md Mar 24, 2024
@jcpitre jcpitre changed the title chore: Replaced the wrong "Bike Allowed" by "Bike Allowance" in Features.md chore: Replaced the wrong "Bike Allowed" by "Bikes Allowance" in Features.md Mar 24, 2024
@jcpitre jcpitre changed the title chore: Replaced the wrong "Bike Allowed" by "Bikes Allowance" in Features.md chore: Corrected typos in Features.md Mar 24, 2024
@jcpitre jcpitre requested a review from emmambd March 25, 2024 15:55
@jcpitre jcpitre self-assigned this Mar 25, 2024
emmambd
emmambd approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor changes expected later in the quarter, but it's good for this to be an accurate reflection of the code

@jcpitre jcpitre mentioned this pull request Sep 5, 2024
Merged
5 tasks
qcdyx
qcdyx approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidgamez
Copy link
Member

@emmambd Is this already fixed as part of the latest feature flags enhancements?

@emmambd
Copy link
Contributor

emmambd commented Oct 23, 2024

@davidgamez Yes! This would override new changes. Can be closed.

@emmambd emmambd closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmambd emmambd emmambd approved these changes

@qcdyx qcdyx qcdyx approved these changes

Assignees

@jcpitre jcpitre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcpitre @davidgamez @emmambd @qcdyx