fix: make built in reporters internal

This commit updates the test runner to make the built in test reporters internal modules. PR-URL: nodejs/node#46092 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> (cherry picked from commit 4788c0d2a02a2e7c7088c6f39d9f13a4209ba863)
MoLow · Feb 7, 2023 · 0743c23 · 0743c23
1 parent a47cacd
commit 0743c23
Showing 1 changed file with 16 additions and 3 deletions.
diff --git a/lib/internal/test_runner/utils.js b/lib/internal/test_runner/utils.js
@@ -1,4 +1,4 @@
-// https://github.com/nodejs/node/blob/12c0571c8fece32d274eaf0ae197c0eb1948fe11/lib/internal/test_runner/utils.js
+// https://github.com/nodejs/node/blob/4788c0d2a02a2e7c7088c6f39d9f13a4209ba863/lib/internal/test_runner/utils.js
 'use strict'
 const {
   ArrayPrototypePush,
@@ -100,13 +100,26 @@ const kBuiltinReporters = new SafeMap([
 const kDefaultReporter = 'tap'
 const kDefaultDestination = 'stdout'
 
+function tryBuiltinReporter (name) {
+  const builtinPath = kBuiltinReporters.get(name)
+
+  if (builtinPath === undefined) {
+    return
+  }
+
+  return require(builtinPath)
+}
+
 async function getReportersMap (reporters, destinations) {
   return SafePromiseAllReturnArrayLike(reporters, async (name, i) => {
     const destination = kBuiltinDestinations.get(destinations[i]) ?? createWriteStream(destinations[i])
 
     // Load the test reporter passed to --test-reporter
-    const reporterSpecifier = kBuiltinReporters.get(name) ?? name
-    let reporter = await import(reporterSpecifier)
+    let reporter = tryBuiltinReporter(name)
+
+    if (reporter === undefined) {
+      reporter = await import(name)
+    }
 
     if (reporter?.default) {
       reporter = reporter.default