support to config root-dir for kubelet #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanxuean
force-pushed
the
root-dir
branch
4 times, most recently
from
ed63b65 to
1b85d9f
Compare
|
Is there some bugs in ci/circleci:build? |
yanxuean
force-pushed
the
root-dir
branch
2 times, most recently
from
9ea4124 to
2eea56d
Compare
pigmej
approved these changes
Sep 4, 2018
There was a problem hiding this comment.
Reviewed 31 of 31 files at r1.
Reviewable status: 0 of 2 approvals obtained
Signed-off-by: yanxuean <[email protected]>
ivan4th
approved these changes
Sep 10, 2018
There was a problem hiding this comment.
Reviewed 29 of 31 files at r1, 1 of 2 files at r2.
Reviewable status: 1 of 2 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yanxuean [email protected]
This change is