-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seems like build/cmd.sh build
fails
#375
Comments
miha-plesko
added a commit
to miha-plesko/virtlet
that referenced
this issue
Aug 4, 2017
Virtlet uses a patch to adjust libvirt-xml-go domain definition. But due to changes in libvirt-xml-go upstream it's no longer possible to apply the patch. With this commit we update the patch so that it now follows the upstream. Also, some changes were conflicting therefore we needed to modify the Virtlet code that relies on those changes. Namely, virtlet's patch suggested following struct for providing bootcmd: ``` DomainCMDLine |-> Args: []QemuArg |-> Envs: []QemuEnv ``` but the upstream code now provides following struct: ``` DomainQEMUCommandline |-> Args: []DomainQEMUCommandlineArg |-> Envs: []DomainQEMUCommandlineEnv ``` So we had to enforce such naming also in Virtlet code. Fixes Mirantis#375 Signed-off-by: Miha Pleško <[email protected]>
ivan4th
pushed a commit
to Mirantis/criproxy
that referenced
this issue
Nov 18, 2017
Virtlet uses a patch to adjust libvirt-xml-go domain definition. But due to changes in libvirt-xml-go upstream it's no longer possible to apply the patch. With this commit we update the patch so that it now follows the upstream. Also, some changes were conflicting therefore we needed to modify the Virtlet code that relies on those changes. Namely, virtlet's patch suggested following struct for providing bootcmd: ``` DomainCMDLine |-> Args: []QemuArg |-> Envs: []QemuEnv ``` but the upstream code now provides following struct: ``` DomainQEMUCommandline |-> Args: []DomainQEMUCommandlineArg |-> Envs: []DomainQEMUCommandlineEnv ``` So we had to enforce such naming also in Virtlet code. Fixes Mirantis/virtlet#375 Signed-off-by: Miha Pleško <[email protected]>
ivan4th
pushed a commit
to Mirantis/criproxy
that referenced
this issue
Nov 18, 2017
Virtlet uses a patch to adjust libvirt-xml-go domain definition. But due to changes in libvirt-xml-go upstream it's no longer possible to apply the patch. With this commit we update the patch so that it now follows the upstream. Also, some changes were conflicting therefore we needed to modify the Virtlet code that relies on those changes. Namely, virtlet's patch suggested following struct for providing bootcmd: ``` DomainCMDLine |-> Args: []QemuArg |-> Envs: []QemuEnv ``` but the upstream code now provides following struct: ``` DomainQEMUCommandline |-> Args: []DomainQEMUCommandlineArg |-> Envs: []DomainQEMUCommandlineEnv ``` So we had to enforce such naming also in Virtlet code. Fixes Mirantis/virtlet#375 Signed-off-by: Miha Pleško <[email protected]>
ivan4th
pushed a commit
to Mirantis/criproxy
that referenced
this issue
Nov 18, 2017
Virtlet uses a patch to adjust libvirt-xml-go domain definition. But due to changes in libvirt-xml-go upstream it's no longer possible to apply the patch. With this commit we update the patch so that it now follows the upstream. Also, some changes were conflicting therefore we needed to modify the Virtlet code that relies on those changes. Namely, virtlet's patch suggested following struct for providing bootcmd: ``` DomainCMDLine |-> Args: []QemuArg |-> Envs: []QemuEnv ``` but the upstream code now provides following struct: ``` DomainQEMUCommandline |-> Args: []DomainQEMUCommandlineArg |-> Envs: []DomainQEMUCommandlineEnv ``` So we had to enforce such naming also in Virtlet code. Fixes Mirantis/virtlet#375 Signed-off-by: Miha Pleško <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just checked out the lastest Virtlet master and run:
where the content of domain.go.rej file is:
I think it's because guys on libvirt-go-xml project added this line.
The text was updated successfully, but these errors were encountered: