Skip to content

Commit

Permalink
virtlet should not have "--+v" option
Browse files Browse the repository at this point in the history
Signed-off-by: yanxuean <[email protected]>
  • Loading branch information
yanxuean committed Aug 21, 2018
1 parent fd888f2 commit 7159a25
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/devel/guidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

Be proffesional. When it's possible - follow general golang [code review guidelines](https://github.com/golang/go/wiki/CodeReviewComments).

## Contribugin guidelines
## Contributing guidelines

Please check out [Effective Go](https://golang.org/doc/effective_go.html) as
a base source of rules for this project.
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ func configForNode(mappings []virtlet_v1.VirtletConfigMapping, localConfig *virt
}
sort.Slice(sortedMappings, func(i, j int) bool {
a, b := sortedMappings[i], sortedMappings[j]
// Iitems that go later in the list take precedence.
// Items that go later in the list take precedence.
return a.Spec.Priority < b.Spec.Priority
})

Expand Down
2 changes: 1 addition & 1 deletion pkg/config/fields.go
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ func (fs *fieldSet) applyDefaults() {

func (fs *fieldSet) addFlags(flagSet *flag.FlagSet) {
for _, f := range fs.fields {
if f.flagName() != "" && !strings.Contains("+", f.flagName()) {
if f.flagName() != "" && !strings.Contains(f.flagName(), "+") {
f.addFlag(flagSet)
}
}
Expand Down

0 comments on commit 7159a25

Please sign in to comment.