-
Notifications
You must be signed in to change notification settings - Fork 128
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove sandboxes with missing netns during startup
Closes #783
- Loading branch information
Showing
6 changed files
with
193 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| /* | ||
| Copyright 2018 Mirantis | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package utils | ||
|
|
||
| import ( | ||
| "bufio" | ||
| "io" | ||
| "os" | ||
| "path/filepath" | ||
| "strings" | ||
|
|
||
| "github.com/golang/glog" | ||
| ) | ||
|
|
||
| type mountEntry struct { | ||
| Source string | ||
| Fs string | ||
| } | ||
|
|
||
| // MountPointChecker provides methods to check if directory entry is a mount point, | ||
| // what is its source and its filesystem | ||
| type MountPointChecker interface { | ||
| CheckMountPointInfo(string) (mountEntry, bool) | ||
| IsPathAnNs(string) bool | ||
| } | ||
|
|
||
| type mountPointChecker struct { | ||
| mountInfo map[string]mountEntry | ||
| } | ||
|
|
||
| var _ MountPointChecker = mountPointChecker{} | ||
|
|
||
| // NewMountPointChecker returns new instance of MountPointChecker | ||
| func NewMountPointChecker() (MountPointChecker, error) { | ||
| file, err := os.Open("/proc/self/mountinfo") | ||
| if err != nil { | ||
| return mountPointChecker{}, err | ||
| } | ||
| defer file.Close() | ||
|
|
||
| mi := make(map[string]mountEntry) | ||
|
|
||
| reader := bufio.NewReader(file) | ||
| for { | ||
| line, err := reader.ReadString('\n') | ||
| if err == io.EOF { | ||
| break | ||
| } | ||
| if err != nil { | ||
| return mountPointChecker{}, err | ||
| } | ||
|
|
||
| // strip eol | ||
| line = strings.Trim(line, "\n") | ||
|
|
||
| // split and interpret entries acording to 3.5 paragraph in | ||
| // https://www.kernel.org/doc/Documentation/filesystems/proc.txt | ||
| // TODO: whitespaces and control chars in names are encoded as | ||
| // octal values (e.g. for "x x": "x\040x") what should be expanded | ||
| // in both mount point source and target | ||
| parts := strings.Split(line, " ") | ||
| mi[parts[4]] = mountEntry{Source: parts[9], Fs: parts[8]} | ||
| } | ||
| return mountPointChecker{mountInfo: mi}, nil | ||
| } | ||
|
|
||
| // CheckMountPointInfo chekcs if entry is a mountpoint and if so returns | ||
| // mountInfo for it | ||
| func (mpc mountPointChecker) CheckMountPointInfo(path string) (mountEntry, bool) { | ||
| entry, ok := mpc.mountInfo[path] | ||
| return entry, ok | ||
| } | ||
|
|
||
| // IsPathAnNs verifies if provided path is mountpoint with nsfs filesystem type | ||
| func (mpc mountPointChecker) IsPathAnNs(path string) bool { | ||
| _, err := os.Stat(path) | ||
| if err != nil { | ||
| if os.IsNotExist(err) { | ||
| glog.Errorf("Cannot verify existence of %q: %v", path, err) | ||
| } | ||
| return false | ||
| } | ||
| realpath, err := filepath.EvalSymlinks(path) | ||
| if err != nil { | ||
| glog.Errorf("Cannot verify real path of %q: %v", path, err) | ||
| return false | ||
| } | ||
|
|
||
| entry, isMountPoint := mpc.CheckMountPointInfo(realpath) | ||
| if !isMountPoint { | ||
| return false | ||
| } | ||
| return entry.Fs == "nsfs" | ||
| } | ||
|
|
||
| type fakeMountPointChecker struct { | ||
| } | ||
|
|
||
| // FakeMountPointChecker is defined there for static type checking and for unittest | ||
| var FakeMountPointChecker MountPointChecker = fakeMountPointChecker{} | ||
|
|
||
| // CheckMountPointInfo is fake implementation for MountPointChecker interface | ||
| func (mpc fakeMountPointChecker) CheckMountPointInfo(path string) (mountEntry, bool) { | ||
| return mountEntry{}, false | ||
| } | ||
|
|
||
| // IsPathAnNs is fake implementation for MountPointChecker interface | ||
| func (mpc fakeMountPointChecker) IsPathAnNs(path string) bool { | ||
| return false | ||
| } |