-
-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update buildTypeDefsAndResolvers.ts #803
Conversation
Could you also add tests, update docs and add a changelog entry? |
Codecov Report
@@ Coverage Diff @@
## master #803 +/- ##
==========================================
+ Coverage 96.02% 96.04% +0.01%
==========================================
Files 79 79
Lines 1687 1694 +7
Branches 337 337
==========================================
+ Hits 1620 1627 +7
Misses 66 66
Partials 1 1
Continue to review full report at Codecov.
|
done, do you think it would be okay? |
I really need this feature, thanks @Carassale! 🎉✨ |
I need this feature for some projects I will be working on soon. @MichalLytek do you think it can be approved? |
Adds a method to build TypeDefs and Resolvers in Sync mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great, thanks! 🙏
@Carassale I've added some docs change, smaller test suite, improved naming and changelog entry. Now it's ready to merge 💪 |
Adds a method to build TypeDefs and Resolvers in Sync mode.