Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildTypeDefsAndResolvers.ts #803

Merged
merged 6 commits into from
Aug 20, 2021

Conversation

Carassale
Copy link
Contributor

Adds a method to build TypeDefs and Resolvers in Sync mode.

@MichalLytek
Copy link
Owner

Could you also add tests, update docs and add a changelog entry?

@MichalLytek MichalLytek self-requested a review March 7, 2021 15:40
@MichalLytek MichalLytek added Community 👨‍👧 Something initiated by a community Enhancement 🆕 New feature or request labels Mar 7, 2021
@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #803 (248d3af) into master (776e458) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
+ Coverage   96.02%   96.04%   +0.01%     
==========================================
  Files          79       79              
  Lines        1687     1694       +7     
  Branches      337      337              
==========================================
+ Hits         1620     1627       +7     
  Misses         66       66              
  Partials        1        1              
Impacted Files Coverage Δ
src/utils/buildTypeDefsAndResolvers.ts 100.00% <100.00%> (ø)
src/utils/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776e458...248d3af. Read the comment docs.

@Carassale
Copy link
Contributor Author

Could you also add tests, update docs and add a changelog entry?

done, do you think it would be okay?

@carlocorradini
Copy link
Contributor

Adds a method to build TypeDefs and Resolvers in Sync mode.

I really need this feature, thanks @Carassale! 🎉✨

@Carassale
Copy link
Contributor Author

I need this feature for some projects I will be working on soon. @MichalLytek do you think it can be approved?

Copy link
Owner

@MichalLytek MichalLytek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great, thanks! 🙏

@MichalLytek
Copy link
Owner

@Carassale I've added some docs change, smaller test suite, improved naming and changelog entry. Now it's ready to merge 💪

@MichalLytek MichalLytek merged commit 094654a into MichalLytek:master Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community 👨‍👧 Something initiated by a community Enhancement 🆕 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants