Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly transform nested array of input type classes #737

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

MichalLytek
Copy link
Owner

Closes #734 🔒

@MichalLytek MichalLytek added the Bugfix 🐛 🔨 PR that fixes a known bug label Oct 20, 2020
@MichalLytek MichalLytek added this to the 1.x versions milestone Oct 20, 2020
@MichalLytek MichalLytek self-assigned this Oct 20, 2020
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #737 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
+ Coverage   95.33%   95.40%   +0.06%     
==========================================
  Files          80       80              
  Lines        1480     1479       -1     
  Branches      294      294              
==========================================
  Hits         1411     1411              
+ Misses         66       65       -1     
  Partials        3        3              
Impacted Files Coverage Δ
src/resolvers/convert-args.ts 100.00% <100.00%> (ø)
src/schema/schema-generator.ts 98.00% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd4f261...a982352. Read the comment docs.

@MichalLytek MichalLytek force-pushed the fix-nested-arrays-inputs branch from 41acc11 to f2d80da Compare October 20, 2020 20:06
Copy link

@blueset blueset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!
I have applied the patch locally and it does fix the issue.

@MichalLytek MichalLytek force-pushed the fix-nested-arrays-inputs branch from f2d80da to a982352 Compare October 23, 2020 18:09
@MichalLytek MichalLytek merged commit 8c7d0a9 into master Oct 23, 2020
@MichalLytek MichalLytek deleted the fix-nested-arrays-inputs branch October 23, 2020 18:09
@MichalLytek MichalLytek modified the milestones: 1.x versions, 1.2 Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 🔨 PR that fixes a known bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested arrays of InputTypes as arguments are incorrectly resolved
2 participants