Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining arguments and implementing resolvers for interface types fields #579

Merged
merged 21 commits into from
Mar 23, 2020

Conversation

MichalLytek
Copy link
Owner

@MichalLytek MichalLytek commented Mar 15, 2020

Revamped and rebased PR #284, originally made by @kl4n4 💪

Closes #260 #261 🔒

@MichalLytek MichalLytek added the Enhancement 🆕 New feature or request label Mar 15, 2020
@MichalLytek MichalLytek added this to the 1.0.0 release milestone Mar 15, 2020
@MichalLytek MichalLytek self-assigned this Mar 15, 2020
@MichalLytek MichalLytek changed the title Kl4n4/arguments for interface fields Arguments for fields of interfaces Mar 15, 2020
@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #579 into master will decrease coverage by 0.05%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
- Coverage   95.01%   94.96%   -0.06%     
==========================================
  Files          77       77              
  Lines        1385     1390       +5     
  Branches      267      272       +5     
==========================================
+ Hits         1316     1320       +4     
- Misses         66       67       +1     
  Partials        3        3              
Impacted Files Coverage Δ
src/metadata/metadata-storage.ts 99.37% <92.85%> (-0.63%) ⬇️
src/schema/schema-generator.ts 96.95% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d1fea...af0dc0f. Read the comment docs.

@MichalLytek MichalLytek force-pushed the kl4n4/arguments-for-interface-fields branch from d6a9122 to 5f1cec1 Compare March 22, 2020 13:03
@MichalLytek MichalLytek changed the title Arguments for fields of interfaces Defining arguments and implementing resolvers for interface types fields Mar 23, 2020
@MichalLytek MichalLytek merged commit 45e118e into master Mar 23, 2020
@MichalLytek MichalLytek deleted the kl4n4/arguments-for-interface-fields branch March 23, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 🆕 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying arguments on interfaces [Feature request] Resolvers for interfaces
1 participant