Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip middlewares stack for simple field resolvers #479

Merged
merged 5 commits into from
Dec 5, 2019

Conversation

MichalLytek
Copy link
Owner

@MichalLytek MichalLytek commented Dec 3, 2019

Closes #254 and #449

@MichalLytek MichalLytek added the Enhancement 🆕 New feature or request label Dec 3, 2019
@MichalLytek MichalLytek added this to the 1.0.0 release milestone Dec 3, 2019
@MichalLytek MichalLytek self-assigned this Dec 3, 2019
@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #479 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
+ Coverage   95.12%   95.14%   +0.01%     
==========================================
  Files          75       75              
  Lines        1314     1318       +4     
  Branches      249      252       +3     
==========================================
+ Hits         1250     1254       +4     
  Misses         61       61              
  Partials        3        3
Impacted Files Coverage Δ
src/decorators/Field.ts 100% <ø> (ø) ⬆️
src/decorators/ObjectType.ts 100% <ø> (ø) ⬆️
src/decorators/Arg.ts 100% <ø> (ø) ⬆️
src/decorators/InterfaceType.ts 100% <ø> (ø) ⬆️
src/decorators/Resolver.ts 100% <ø> (ø) ⬆️
src/resolvers/create.ts 100% <100%> (ø) ⬆️
src/schema/schema-generator.ts 96.74% <100%> (+0.05%) ⬆️
src/decorators/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3567149...b11e43c. Read the comment docs.

@MichalLytek MichalLytek marked this pull request as ready for review December 4, 2019 21:16
@MichalLytek MichalLytek merged commit 1087d30 into master Dec 5, 2019
@MichalLytek MichalLytek deleted the simple-resolvers branch December 5, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 🆕 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too slow for simple large list
1 participant