Make GraphQL packages peer dependencies #239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
graphql
and@types/graphql
a peer dependencies. This will allow for better interop with other GraphQL ecosystem libraries without version conflict issues.It also introduces the strict version check in runtime using
node-semver
to ensure that users update the peer dependencies on TypeGraphQL update - this trick will limit all weird runtime errors that might occur when TypeGraphQL uses some newgraphql-js
features.