-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate complete source maps #6756
Generate complete source maps #6756
Conversation
The source maps generated previously were mapping the bundled files to the post-Babel files - they weren't showing mapping to the source files as written. It looks like this was a result of `reactify` being used in addition to babel - that transformation must have dropped the source maps. `reactify` still needs to be listed as a dependency because it is an unlisted requirement of the `boron` package, which we use. We don't need to use it to create our bundles though, as Babel already performs the transformations we need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome work! Great find! I suspect that we now don't need reactify
? Can we uninstall it as a dependency?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the PR again and this LGTM! Thanks!
I should add some context about that - @kumavis already created an issue for this problem. It looks like that library isn't actively maintained though. Perhaps it's worth investigating a few of the forks discussed in this issue. But yeah, as long as we're still using Edit: Well, after reading that issue again, that fork doesn't show that much promise for us. The alternate proposed, |
We're using |
I was curious whether removing |
The source maps generated previously were mapping the bundled files to the post-Babel files - they weren't mapping to the source files as written.
It looks like this was a result of
reactify
being used in addition to babel - that transformation must have dropped the source maps.reactify
still needs to be listed as a dependency because it is an unlisted requirement of theboron
package, which we use. We don't need to use it to create our bundles though, as Babel already performs the transformations we need.Before changes:
After changes: