Enhancement for doFuture implementation and stable parallel RNG in sim_gs_n #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdblischak
requested changes
Apr 22, 2024
R/sim_gs_n.R
Outdated
| # test = wlr, | ||
| # cut = list(ia1 = ia1, ia2 = ia2, fa = fa), | ||
| # weight = fh(rho = 0, gamma = 0) | ||
| # ) |
There was a problem hiding this comment.
Please add back the apostrophe (#') as this removed this example from the documentation. Also note that if you are using RStudio, you can execute this code with Ctrl-Enter without having to uncomment it.
| @@ -4,14 +4,14 @@ | |||
| # See helper-sim_gs_n.R for helper functions | |||
|
|
|||
| test_that("Test 1: regular logrank test", { | |||
| # set.seed(2024) | |||
There was a problem hiding this comment.
This was unfortunate timing as all the sim_gs_n() tests were commented out. Once #229 is merged, you can rebase on top of that, and then the tests will run.
| # ), | ||
| # "If you want to run different tests at each cutting" | ||
| # ) | ||
| expect_equal(1 + 1, 2) |
There was a problem hiding this comment.
In the future, instead of commenting out a test, please add skip("The reason the test needs to be skipped"). This keeps the git diff's nicer. In other words, it is easier to see what needed to be change to fix a test if it wasn't completely commented out previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for
sim_gs_n()to have a parallel adaptor similar tosim_fixed_n()(xref: #110).A seed is now set prior to the function call instead of passed as an argument.
Function now uses
%douture%to run iterations ofn_simin parallel.Addresses open issue (xref: #205).
Sequential backend still available (and default) to avoid any delays in development.
Please update "Remove seed argument from
sim_gs_n()in (xref: Merck/gsDesign2#288) as part of the implementation.PR will be updated again following approval of PR (xref: #229) as it will need to combine updates to
sim_gs_nfrom that PR.