-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standardize wlr
and maxcombo
output
#227
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LittleBeannie
changed the title
standardize
standardize Apr 10, 2024
fh_weight
outputwlr
and maxcombo
output
keaven
approved these changes
Apr 11, 2024
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers:
Unify the output of
wlr
andmaxcombo
as a list containingmethod
,parameter
,estimate
,se
,z
p_value
andcorr
(only for maxcombo).Cleanup
fh_weight
,mb_weight
andearly_zero_weight
, which only assigns weights to subjects. And the calculation of the z-score, estimation, se, is done inwlr()
.Update
maxcombo
.sim_fixed_n
to fit into the new output ofwlr
ormaxcombo
.