Removed use of obsolete LCID code usage in culture converter. #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joren-Thijs
changed the title
tarekgh
approved these changes
Oct 13, 2021
|
Thank you for your pull request. I will look into it tomorrow. Matthias |
|
Thank you for offering new unit tests. In case you reproduce the erroneous behavior before the fix, those would be very welcome. Matthias |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #412
I have removed the use of
CultureInfo.CurrentCulture.LCIDin CultureConverter and replaced it withCultureInfo.CurrentCulture.Nameas proposed by @tarekgh in this issue.Since this is a small change i have gone ahead and submitted a quick PR.
Unfortunatly i cannot succesfully run the net Framework tests on my machine. Since it wrongly identifies the path to the test data files. The net core test however i can run succesfully and are passing for me.
I am therefore going to create the pull request so i can use this projects CI tests.
I have also created another local commit expanding the targeted frameworks of the testing project to include both net 5 and net 6. let me know if you want this commit to be included.
Also do you want any specific new unit tests to be included?