-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swav checks #900
Swav checks #900
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@otaj If I made a mistake let me know. I don't know why other tests are not running. Locally its working at least CPU versions |
Not sure why azure steps are failing. CPU runs are working on my local system. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Finally CI/CD passing on azure after so much time 🥺 |
@otaj need someone approval to run other tests. Azure pipelines and tests are passing. Please enable other tests so that this can get approved :) |
Hey, @Atharva-Phatak - Done! :) Feel free to ping us again in case you need approval for the tests. Since it's a weekend, I thought I'll help Ota and you out with this small little approval. 🚀 |
@krshrimali Yo thank you so much :) |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@krshrimali could you trigger other runs. I want to check if mypy is skipping some lines of check as they are unnecessary ? |
Done! :)) |
for more information, see https://pre-commit.ci
Thanks for triggering the runs. |
I am closing this PR and adding all the changes to a new PR as I have to contact someone to trigger the runs. |
What does this PR do?
Quality checks for implementations of SWAV #839
Couple of points I would like to highlight.
Fixes part of #839
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃