Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swav checks #900

Closed

Conversation

Atharva-Phatak
Copy link
Contributor

@Atharva-Phatak Atharva-Phatak commented Oct 6, 2022

What does this PR do?

Quality checks for implementations of SWAV #839

Couple of points I would like to highlight.

  • Right now bolts is focused on standard datasets like CIFAR10, etc but it will be very amazing if we can adapt SSL module for custom tasks.
  • The SSL fine tuner is just a normal lightingModule we can remove it and let the user create one according to his/her needs. We will just provide the basic models and functionalities required for implementing SSL tasks.
  • These changes will require a substantial rewrite and we can discuss this in further issues.

Fixes part of #839

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Atharva-Phatak
Copy link
Contributor Author

@otaj If I made a mistake let me know. I don't know why other tests are not running. Locally its working at least CPU versions

@Atharva-Phatak
Copy link
Contributor Author

Not sure why azure steps are failing. CPU runs are working on my local system.

@Atharva-Phatak
Copy link
Contributor Author

Finally CI/CD passing on azure after so much time 🥺

@Atharva-Phatak
Copy link
Contributor Author

@otaj need someone approval to run other tests. Azure pipelines and tests are passing. Please enable other tests so that this can get approved :)

@krshrimali
Copy link

@otaj need someone approval to run other tests. Azure pipelines and tests are passing. Please enable other tests so that this can get approved :)

Hey, @Atharva-Phatak - Done! :) Feel free to ping us again in case you need approval for the tests. Since it's a weekend, I thought I'll help Ota and you out with this small little approval. 🚀

@Atharva-Phatak
Copy link
Contributor Author

@krshrimali Yo thank you so much :)

@Atharva-Phatak
Copy link
Contributor Author

@krshrimali could you trigger other runs. I want to check if mypy is skipping some lines of check as they are unnecessary ?

@krshrimali
Copy link

@krshrimali could you trigger other runs. I want to check if mypy is skipping some lines of check as they are unnecessary ?

Done! :))

@Atharva-Phatak
Copy link
Contributor Author

Thanks for triggering the runs.

@Atharva-Phatak
Copy link
Contributor Author

I am closing this PR and adding all the changes to a new PR as I have to contact someone to trigger the runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants