-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revision of BYOL module and tests #874
Conversation
… class docstrings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @matsumotosan! Thank you for this PR. I have to say, I love what you've done with byol_module
in general, the meat of this module is now much more readable.
However, I left couple comments, which are mostly related to passing arguments around (similar to my comments in #873)
@otaj I realized that the BYOL module is initialized with |
What does this PR do?
Fixes part of #839
pl_bolts.models.self_supervised.byol.byol_module.BYOL
pl_bolts.models.self_supervised.byol.models.MLP
pl_bolts.models.self_supervised.byol.models.SiameseArm
pl_bolts.tests.models.self_supervised.test_models.test_byol
I cannot fix the CLI script as I do not have a GPU
pl_bolts.tests.models.self_supervised.test_models.test_ssl_scripts.test_cli_run_ssl_byol
Summary
BYOL
to calculate loss for given online and target viewsBYOL
SiameseArm
since it was not being used for target network and move toBYOL
test_byol
to use SimCLR transforms instead of CPC transformsBefore submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃