Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Pass db to AbstractIterator #76

Closed
vweevers opened this issue Sep 15, 2019 · 0 comments · Fixed by #77
Closed

Pass db to AbstractIterator #76

vweevers opened this issue Sep 15, 2019 · 0 comments · Fixed by #77
Labels
cleanup Housekeeping good first issue Good for newcomers semver-patch Bug fixes that are backward compatible

Comments

@vweevers
Copy link
Member

We incorrectly pass an options object to AbstractIterator here:

deferred-leveldown/deferred-iterator.js

Lines 4 to 5 in 2e45a79

function DeferredIterator (options) {
AbstractIterator.call(this, options)

Should be the db. Either the deferred-leveldown instance or the underlying db. The former would be more correct in terms of abstract-leveldown compliance.

Tagging with cleanup instead of bug because nothing is affected.
@vweevers vweevers added semver-patch Bug fixes that are backward compatible cleanup Housekeeping labels Sep 15, 2019
@vweevers vweevers added the good first issue Good for newcomers label Sep 15, 2019
vweevers added a commit that referenced this issue Sep 20, 2019
@vweevers
Pass db to AbstractIterator (closes #76)
b5d3b98
@vweevers vweevers mentioned this issue Sep 20, 2019
Merged
vweevers added a commit that referenced this issue Sep 20, 2019
@vweevers
Include abstract test suite (#77)
c64392a 
* Pass db to AbstractIterator (closes #76)
* Include abstract test suite
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cleanup Housekeeping good first issue Good for newcomers semver-patch Bug fixes that are backward compatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include abstract test suite Level/deferred-leveldown
1 participant
@vweevers