This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 299
LIVE-2162 Solana fixes after initial staking #4969
Open
ghost
wants to merge
10
commits into
develop
Choose a base branch
from
family/solana
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* solana invert validator commision and total stake * solana conditionaly hide ledger by figment TC when staking * solana add use all amount stake warning * solana refactor delegation CTA * solana disable hover on non choosable validators * solana fix renamed useValidators in LLC * solana fix lint issues
Coverage report
Test suite run success2 tests passing in 2 suites.Report generated by 🧪jest coverage report action from 54102a4 |
ghost
mentioned this pull request
May 9, 2022
2 tasks
ghost
commented
May 12, 2022
ghost
marked this pull request as ready for review
May 13, 2022 15:05
ghost
self-requested a review
as a code owner
May 13, 2022 15:43
henri-ly
approved these changes
May 16, 2022
/generate-screenshots |
ghost
self-requested a review
as a code owner
May 17, 2022 08:51
/generate-screenshots |
ghost
added
the
feature ready
label
May 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦒 Context (issues, jira)
https://ledgerhq.atlassian.net/browse/LIVE-2162
💻 Description / Demo (image or video)
Specs of the changes are described here: https://docs.google.com/document/d/1QvlLnoLBkXZ3xul7cHajYzqVjolSTj0tJ64YPfkjvG8/edit
🖤 Expectations to reach
PR must pass CI, rebase develop if conflicts. Thanks!