add healthcheck #1149
Merged
add healthcheck #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EDIT: nevermind, the healthcheck worked once I switched to |
|
Hey, that's pretty cool, thank you! |
|
since jsregexp is optional, it is better to replace error with warning. |
mathjiajia
reviewed
Apr 1, 2024
|
Ay, thanks for the suggestions, good points 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I wasn't sure if the way I'd installed jsregexp was working, so I've tried to implement a
:checkhealth. Let meI'm not sure if I've formatted the messages properly. Also, on my machine the
require("luasnip.util.jsregexp")raises an exception instead of returningfalse, but I don't think that that's an issue unless luasnip needs more than one check in the future.