Native (Kotlin): Fix a bug with Instant.plus
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-g
approved these changes
Apr 27, 2020
core/nativeMain/src/Instant.kt
Outdated
| @@ -202,24 +202,24 @@ actual fun Instant.plus(period: CalendarPeriod, zone: TimeZone): Instant { | |||
| minutes.toLong() * SECONDS_PER_MINUTE, | |||
| hours.toLong() * SECONDS_PER_HOUR)) | |||
| } | |||
| val localDateTime = toLocalDateTime(zone) | |||
| val localDateTime = with (zone) { toZonedLocalDateTime() } | |||
There was a problem hiding this comment.
For internal use it might be clearer to introduce top level extension Instant.toZonedDateTime(zone).
Member extensions inside TimeZone are somewhat experimental.
There was a problem with `Instant.plus` failing to adjust an intermediate date due to offset changing. This led to behaviour different from other platforms and `plus` and `periodUntil` not being inverse operations.
dkhalanskyjb
force-pushed
the
instant-fix
branch
from
5962212 to
c2fb129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem with
Instant.plusfailing to adjust anintermediate date due to offset changing. This led to behaviour
different from other platforms and
plusandperiodUntilnotbeing inverse operations.