feat(*) refactor and simplify parsing of ingress rules to kong config #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking changes - KongIngress overrides for Service and Upstream will now be picked up from annotation on the service and not the route. Changelog: - Directly translate to Kong configuration objects Previously, the Ingress rules were parsed into Nginx Server and Location blocks, and then translated to Kong configuration. This was more complicated and information was lost during translation. - Translation is now done to an intermediate Kong state and then further translated to the final format. The final format will differ, based on if Kong is running in a db or a db-less mode. - Method based routes are now supported (#202) - Default backend in Ingress rules is now respected and a default fallback route in Kong will be created if a default backend exists in one of the Ingress objects. If multiple Ingress objects have a default backed, the Ingress created first will be respected. Fix #202 Fix #241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
from annotation on the service and not the route.
Changelog:
Previously, the Ingress rules were parsed into Nginx Server and
Location blocks, and then translated to Kong configuration. This was
more complicated and information was lost during translation.
translated to the final format. The final format will differ, based on
if Kong is running in a db or a db-less mode.
fallback route in Kong will be created if a default backend exists in
one of the Ingress objects. If multiple Ingress objects have a default
backed, the Ingress created first will be respected.
Fix #202
Fix #241