Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Cookie expires): Invalid date on cookie expires #7614

Merged
merged 2 commits into from
Jun 28, 2024
Merged

fix(Cookie expires): Invalid date on cookie expires #7614

merged 2 commits into from
Jun 28, 2024

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Jun 28, 2024 •
edited
Loading

Highlights:

  • Fixes an issue where the after-response script would execute even if there was no script defined
  • Fixes an issue where cookie expiration dates would be set to an Invalid date when running after-response scripts
  • Fixes an issue where invalid expiration dates on cookies would not allow users to copy requests as cURL
  • Added extra checks for invalid dates on cookie.expires on both the UI and libcurl to provide fallbacks instead of error

Closes #7604, #7611
Closes INS-4082

@gatzjames gatzjames self-assigned this Jun 28, 2024
@gatzjames gatzjames requested a review from a team June 28, 2024 10:55
@gatzjames gatzjames force-pushed the fix/after-response-cookies branch from 7b146c7 to 9125d91 Compare June 28, 2024 13:48
@gatzjames gatzjames merged commit 3ab6165 into Kong:develop Jun 28, 2024
7 checks passed
@gatzjames gatzjames deleted the fix/after-response-cookies branch June 28, 2024 14:06
stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request Jun 30, 2024
@gatzjames @stefancruz
fix(Cookie expires): Invalid date on cookie expires (Kong#7614)
2094687 
* Fix always running after-response script

* Fix invalid date in cookies
CurryYangxx pushed a commit that referenced this pull request Jul 5, 2024
@gatzjames @CurryYangxx
fix(Cookie expires): Invalid date on cookie expires (#7614)
771999f 
* Fix always running after-response script

* Fix invalid date in cookies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filfreire filfreire filfreire approved these changes

Assignees

@gatzjames gatzjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manage Cookies Fails to Load
2 participants
@gatzjames @filfreire