Refactor/replace request, modules for each monitor #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a lint config that roughly represents the existing conventions.
Each monitor provides an async generator that yields an endless stream of screens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on the lint config PR, each monitor (perf, stocks, weather) has been separated into its own module. Each module provides an async generator that can be used as a lazy stream, returning a fresh screen upon request. It's consistent across each, and allows us to keep the timing in a single location without needing to proliferate global variables any more than the code already was.
Tests are minimal, but a little better than no tests at all.
I'd be interested in hearing your thoughts. I don't know the full scope of where you're heading, so i really have no idea how compatible this direction is.