Use a new KAGGLE_GRPC_DATA_PROXY_URL env variable for gRPC proxying #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosbo
approved these changes
Dec 5, 2023
psbang
reviewed
Dec 5, 2023
psbang
reviewed
Dec 5, 2023
psbang
reviewed
Dec 6, 2023
| @@ -29,7 +30,6 @@ def test_disabled(self): | |||
| env.set("KAGGLE_DATA_PROXY_TOKEN", "foobar") | |||
| env.set("KAGGLE_DATA_PROXY_URL", self.http_endpoint) | |||
| env.set("KAGGLE_GRPC_DATA_PROXY_URL", self.grpc_endpoint) | |||
| env.set("KAGGLE_GOOGLE_GENERATIVE_AI_USE_REST_ONLY", "True") | |||
There was a problem hiding this comment.
@Philmod I set this env variable because the test is creating the HTTP server endpoint. Without this, palm.list_models() is actually calling the gRPC endpoint, which is not being spun up in this test, so this will always pass and isn't testing what we want it to test.
There was a problem hiding this comment.
That was the goal: this test file is named *_disabled, I wanted to check it wasn't hitting the http server.
There was a problem hiding this comment.
@psbang Unless I'm missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://b/308644984