Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logabssinh #70

Merged
merged 3 commits into from
Jun 2, 2023
Merged

add logabssinh #70

merged 3 commits into from
Jun 2, 2023

Conversation

longemen3000
Copy link
Contributor

closes #69 . Implementation, chainrules and tests done

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mainly good, thank you!

Can you add it to the docs and bump the version number?

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional point that I missed yesterday: Can you also add a test for the ChainRules definition in the respective test file?

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@devmotion devmotion merged commit 24fcdab into JuliaStats:master Jun 2, 2023
@oscardssmith
Copy link
Contributor

One last thing is that this will be pretty inaccurate when the output is near zero. I'm not sure if it matters, but I figured I would bring it up.

@longemen3000
Copy link
Contributor Author

in my particular case, the more interesting points are near x = 1, but it is a valid point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logabssinh
3 participants