-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax print tests #476
Relax print tests #476
Conversation
Why is this tested at all? Doesn't it just directly call a If we really want to test it, I find it best to just interpolate the whole type, so something like:
|
That is a good question. That code was added in but that test was added in 799c444 |
The show method for Partials used to fail which was why the test was added in #437. I've applied the proposal from #476 (comment). |
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
==========================================
+ Coverage 84.92% 88.86% +3.94%
==========================================
Files 10 10
Lines 703 826 +123
==========================================
+ Hits 597 734 +137
+ Misses 106 92 -14
Continue to review full report at Codecov.
|
Wether or not a space is printed changes depending on the julia version.
So we use a regex.
I also hard coded to use
Int32
since that simpifies the regex