Add needs_loss and needs_training_losses control traits
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs EarlyStopping.jl version 0.3 - Adds the traits `needs_loss`, `needs_training_losses` that were removed from EarlyStopping. - Changes the logic about how these are handled to correct previously unexpected behaviour discovered in MLJIteration.jl; see [this issue](JuliaAI/MLJIteration.jl#36). The traits have a slightly new interpretation: have `train!` throw an error if the trait is `true` for some control provided and the model has not been overloaded for `loss`/`training_losses`. update readme
Codecov Report
@@ Coverage Diff @@
## dev #51 +/- ##
==========================================
- Coverage 96.30% 96.23% -0.08%
==========================================
Files 8 8
Lines 298 292 -6
==========================================
- Hits 287 281 -6
Misses 11 11
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs EarlyStopping.jl version 0.3
Adds the traits
needs_loss,needs_training_lossesthat wereremoved from EarlyStopping in v0.3.0
Changes the logic about how these are handled to correct previously
unexpected behaviour discovered in MLJIteration.jl; see this
issue. The
traits have a slightly new interpretation: have
train!throw anerror if the trait is
truefor some control provided and the modelhas not been overloaded for
loss/training_losses.Resolves JuliaAI/MLJIteration.jl#36.