DateTime support #17
Draft
DateTime support #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now possible to get the current date and time with unsafe code using the GetTime function.
Currently, the only constructor requires values for year, month, day, hour, minute and second and all 6 can be manually retrieved afterwards. Additionally Now is support which means there is now a way to get the time outside of unsafe code.
Added everything i could without adding other files that may have their own issues.
Updated DateTime constructors to somewhat deal with the lack of exception support. Results still vary from dotnet behaviour but it does work. Added DateTime.DoubleDateToTicks and FromOADate, another place where the lack of exception supports means some weird changes had to be made. It looks like as soon as exceptions are supported, this file could be replaced with the proper version. Added platform specific version of DateTime to hold s_systemSupportsLeapSeconds.
This ideally means that DateTime shouldn't have to be looked at much after #17, the only major thing missing now is exception handling.
|
Before merging, every function needs to be at least somewhat tested, especially those that I had to modify to compile and run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As many public functions and properties as possible have been added with EFI_TIME forming the backend for DateTime.Now.
The lack of exception support leads to most of the constructors have slightly modified results to normal with invalid inputs being replaced with defaults rather than causing crashes.
I am currently considering if NotNullWhenAttribute, TypeCode, IConvertible and IFormatProvider are worth adding for the small number of functions they add or make identical to the dotnet version.