-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core:release 9.9.2 #6
base: latest
Are you sure you want to change the base?
Changes from all commits
dcfc3de
cb85973
fec3c94
898bcfd
1cdc662
10256e8
aa5d7b1
badeac2
12f103c
d5c3289
328f63c
ef4c975
3cefdf6
4dfc7d2
61d5771
53cda32
b1db070
9e6686b
9122fb6
7d89b55
fd6479f
2d1d8d0
8f94ae8
e4c7a41
6278fe4
2508a83
5c6759d
18b42a4
41291ba
83fed2e
447a8d7
6574dc9
4b57b95
e3f0fd4
2d84091
4a36d78
6b55646
6109960
4ef4830
04d6910
d185c9b
15be6dd
92e71e6
93883bb
71c6848
2273183
55639ef
a8e666e
ac937d4
29204c8
6f0d7ce
4646768
8b8ce7a
941d0d7
7b584d3
e5451e1
3b8b111
2490b49
6f33d74
3101a40
1c8d41d
094c4ea
76dab91
d8fa116
5e4fa18
1c1adae
dbe7d98
9214be9
a947f25
86b05fc
4e81a6a
91e46a3
a303ddd
1a9ac86
12587fa
4e965ad
a44ab26
2986f4e
7342c24
df58b0c
d7e462b
3fd7a48
ed4add1
24d5350
2404c7e
e674987
8035725
1772276
7e61151
ec105f4
fefd509
366c07e
63d6a73
6ca609e
949d8f8
d3c0b1e
61d9a90
ecfa213
96f4e4e
1b61379
47f6f76
0e69c92
e7298de
a2c8016
340a330
73068d6
f846ad3
365580a
dd90f9e
feac87c
2076368
81137fc
b80d048
538a4cc
ddb8be0
034c729
6deae9e
f54b155
c4bed31
7214149
eae4f57
105fa2b
8d4060a
be6ae96
591130d
50a7bc8
092f41f
5208f74
d13a20b
b28dbb1
e7ab206
f9b2e18
f6909a0
8b7dbc8
8206c4f
b1c4770
ab40dab
53ed632
b84d907
9cd6603
820e983
1e09334
2d7fc3d
1c25a1d
75786ad
99ccae3
5795987
2072705
bb03036
43f2374
be1e6da
20dd44f
60a7ee5
95e2cb1
4d57928
977fd57
534ad77
feb54f7
70cd88d
5a74478
95d009e
4c8ba0a
e6a8a17
874c0eb
802ea73
57eef8d
9561fa7
2f2ee15
a2f8af0
f7b41a3
62c4604
10458ff
44be07c
2902d4c
dab3042
687cfaf
6e11eb2
3ffc08b
3162620
852dd8b
7f541e8
286739c
7ee15bb
f36dc59
720b4d8
f75da94
62c71e5
ecd2d23
780afc5
75a3f12
080a0f2
ccd8420
ec57f5f
e19bff0
7dbef6f
66fc8c9
6995303
16b7367
475285b
eb6498d
1bd39e7
8cbf1a7
534bbe8
f00359f
3c74ec0
884bbde
69d9f01
5dffd11
e32284a
92e6f07
ef1c368
33cf580
78293ad
6edfe2f
2c1b369
2d530a5
523ad85
4906f3d
ca84b22
4bf1901
1be8e95
b87ba24
cfdf214
e362c6d
2af31dd
d463a6f
c0bcc2a
ac8eb39
8905037
fecfcf4
bc9b14d
f3ac7b7
cf52b8b
8a911da
687ab12
28e8761
aabf345
52bcaf6
a598b7b
3b2951a
d369c77
a07f4e0
ecd7190
a7bfc6d
5319e48
a481f57
f7da341
ab9ddc0
1764a37
7f6c997
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,8 +11,12 @@ const localConfigs = readdir(__dirname) | |
module.exports = { | ||
root: true, | ||
ignorePatterns: [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR contains console logs. Please review or remove them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR contains console logs. Please review or remove them. |
||
'tap-testdir*/', | ||
'/node_modules/.bin/', | ||
'/node_modules/.cache/', | ||
'docs/**', | ||
'smoke-tests/**', | ||
'mock-globals/**', | ||
'mock-registry/**', | ||
'workspaces/**', | ||
], | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
const { resolve, relative } = require('path') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file contains at least one console log. Please remove any present. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file contains at least one console log. Please remove any present. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR contains console logs. Please review or remove them. |
||
|
||
// Create an override to lockdown a file to es6 syntax only | ||
// and only allow it to require an allowlist of files | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR contains leftover multi-line comments. Please review or remove them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR contains leftover multi-line comments. Please review or remove them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR contains leftover multi-line comments. Please review or remove them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR contains leftover multi-line comments. Please review or remove them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR contains leftover multi-line comments. Please review or remove them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR contains leftover multi-line comments. Please review or remove them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR contains leftover multi-line comments. Please review or remove them. |
||
const rel = (p) => relative(__dirname, resolve(__dirname, p)) | ||
const braces = (a) => a.length > 1 ? `{${a.map(rel).join(',')}}` : a[0] | ||
|
||
const es6Files = (e) => Object.entries(e).map(([file, allow]) => ({ | ||
files: `./${rel(file)}`, | ||
parserOptions: { | ||
ecmaVersion: 6, | ||
}, | ||
rules: Array.isArray(allow) ? { | ||
'node/no-restricted-require': ['error', [{ | ||
name: ['/**', `!${__dirname}/${braces(allow)}`], | ||
message: `This file can only require: ${allow.join(',')}`, | ||
}]], | ||
} : {}, | ||
})) | ||
|
||
module.exports = { | ||
rules: { | ||
'no-console': 'error', | ||
}, | ||
overrides: es6Files({ | ||
'index.js': ['lib/cli.js'], | ||
'bin/npm-cli.js': ['lib/cli.js'], | ||
'lib/cli.js': ['lib/cli/validate-engines.js'], | ||
'lib/cli/validate-engines.js': ['package.json'], | ||
// TODO: This file should also have its requires restricted as well since it | ||
// is an entry point but it currently pulls in config definitions which have | ||
// a large require graph, so that is not currently feasible. A future config | ||
// refactor should keep that in mind and see if only config definitions can | ||
// be exported in a way that is compatible with ES6. | ||
'bin/npx-cli.js': null, | ||
}), | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,28 @@ | ||
/node_modules/** linguist-generated=false | ||
Ishmaello marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file contains at least one console log. Please remove any present. |
||
/package-lock.json linguist-generated=false | ||
# normalize all line endings by default | ||
* text=auto | ||
|
||
# our shell/bin scripts always need to be LF | ||
/bin/* text eol=lf | ||
/workspaces/arborist/bin/index.js text eol=lf | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file contains at least one console log. Please remove any present. |
||
/configure text eol=lf | ||
|
||
# our cmd scripts always need to be CRLF | ||
/bin/**/*.cmd text eol=crlf | ||
|
||
# ignore all line endings in node_modules since we dont control that | ||
/node_modules/** -text | ||
|
||
# the files we write should be LF so they can be generated cross platform | ||
/node_modules/.gitignore text eol=lf | ||
/workspaces/arborist/test/fixtures/.gitignore text eol=lf | ||
/DEPENDENCIES.md text eol=lf | ||
/DEPENDENCIES.json text eol=lf | ||
/AUTHORS text eol=lf | ||
|
||
# fixture tarballs should be treated as binary | ||
/workspaces/*/test/fixtures/**/*.tgz binary | ||
|
||
# these hint to GitHub to show these files as not generated so they default to | ||
# showing the full diff in pull requests | ||
/node_modules/** linguist-generated=false | ||
/package-lock.json linguist-generated=false |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
name: 🐞 Bug | ||
description: File a bug/issue against the latest version of npm | ||
title: "[BUG] <title>" | ||
labels: [Bug, Needs Triage] | ||
body: | ||
- type: checkboxes | ||
attributes: | ||
label: Is there an existing issue for this? | ||
description: Please [search here](https://github.com/npm/cli/issues) to see if an issue already exists for your problem. | ||
options: | ||
- label: I have searched the existing issues | ||
required: true | ||
- type: checkboxes | ||
attributes: | ||
label: This issue exists in the latest npm version | ||
description: Please make sure you have installed the latest npm and verified it is still an issue. | ||
options: | ||
- label: I am using the latest npm | ||
required: true | ||
- type: textarea | ||
attributes: | ||
label: Current Behavior | ||
description: A clear & concise description of what you're experiencing. | ||
validations: | ||
required: false | ||
- type: textarea | ||
attributes: | ||
label: Expected Behavior | ||
description: A clear & concise description of what you expected to happen. | ||
validations: | ||
required: false | ||
- type: textarea | ||
attributes: | ||
label: Steps To Reproduce | ||
description: Steps to reproduce the behavior. | ||
value: | | ||
1. In this environment... | ||
2. With this config... | ||
3. Run '...' | ||
4. See error... | ||
validations: | ||
required: false | ||
- type: textarea | ||
attributes: | ||
label: Environment | ||
description: | | ||
examples: | ||
- **`npm -v`**: **npm**: 10.0.0 | ||
- **`node -v`**: **Node.js**: 18.0.0 | ||
- **OS Name**: Ubuntu 20.04 | ||
- **System Model Name**: Macbook Pro | ||
- **`npm config ls`**: `; "user" config from ...` | ||
value: | | ||
- npm: | ||
- Node.js: | ||
- OS Name: | ||
- System Model Name: | ||
- npm config: | ||
```ini | ||
; copy and paste output from `npm config ls` here | ||
``` | ||
validations: | ||
required: false |
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
# This file is automatically added by @npmcli/template-oss. Do not edit. | ||
|
||
name: 'Create Check' | ||
inputs: | ||
name: | ||
required: true | ||
token: | ||
required: true | ||
sha: | ||
required: true | ||
check-name: | ||
default: '' | ||
outputs: | ||
check-id: | ||
value: ${{ steps.create-check.outputs.check_id }} | ||
runs: | ||
using: "composite" | ||
steps: | ||
- name: Get Workflow Job | ||
uses: actions/github-script@v7 | ||
id: workflow | ||
env: | ||
JOB_NAME: "${{ inputs.name }}" | ||
SHA: "${{ inputs.sha }}" | ||
with: | ||
result-encoding: string | ||
script: | | ||
const { repo: { owner, repo}, runId, serverUrl } = context | ||
const { JOB_NAME, SHA } = process.env | ||
|
||
const job = await github.rest.actions.listJobsForWorkflowRun({ | ||
owner, | ||
repo, | ||
run_id: runId, | ||
per_page: 100 | ||
}).then(r => r.data.jobs.find(j => j.name.endsWith(JOB_NAME))) | ||
|
||
return [ | ||
`This check is assosciated with ${serverUrl}/${owner}/${repo}/commit/${SHA}.`, | ||
'Run logs:', | ||
job?.html_url || `could not be found for a job ending with: "${JOB_NAME}"`, | ||
].join(' ') | ||
- name: Create Check | ||
uses: LouisBrunner/[email protected] | ||
id: create-check | ||
with: | ||
token: ${{ inputs.token }} | ||
sha: ${{ inputs.sha }} | ||
status: in_progress | ||
name: ${{ inputs.check-name || inputs.name }} | ||
output: | | ||
{"summary":"${{ steps.workflow.outputs.result }}"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains at least one console log. Please remove any present.