Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
IBufferProtocol
tommap
. Throws aNotImplementedException
if the length does not fit in aint
.For the case of bigger files I think we'll have to rework
IPythonBuffer
. My initial thoughts on changes would be:nint
in place ofint
where applicable (probably where CPython usesPy_ssize_t
).AsSpan
/AsReadOnlySpan
methods to have annint start
argument.nint
arithmetic instead ofint
.Marking as draft since I need to do more testing (and maybe write some tests). @BCSharp I'm not sure if you looked at/thought about this before so if you have any feedback would appreciate it.
Related to #1408