libtool errors with -flto and -fno-common

[nivedita76]

99-no-common.txt

I'm using this hack (value for lt_cv_sys_global_pipe copied from /usr/bin/libtool) to work around the configure failure and subsequent empty pipe error with libtool.

[elsandosgrande]

Empty pipe? Like, with sed? if so, I ran into that when trying to recompile my world with GCC 10 pre-release.

[nivedita76]

Yup, the sed error.

[elsandosgrande]

Pardon me if I am mistaken because I am on my phone, but that link seems to be pointing to a file which does not exist.

[nivedita76]

Pardon me if I am mistaken because I am on my phone, but that link seems to be pointing to a file which does not exist.

Not sure what you mean? It seems to download fine for me. Even on a phone.

[InBetweenNames]

Thanks for posting this! We may need to include your bashrc.d hook or something like it in GentooLTO for GCC 10. Not sure if the upstream Gentoo devs will support us on this one.

[InBetweenNames]

It seems that copying the system libtool over also works... although I know that's a hack and a half.

[InBetweenNames]

I managed to do this without the bashrc.d hook with a new type of override:

sample/package "export lt_cv_sys_global_symbol_pipe=\"sed -n -e 's/^.*[ ]\\([ABCDGIRSTW][ABCDGIRSTW]*\\)[ ][ ]*\\([_A-Za-z][_A-Za-z0-9]*\\)\$/\\1 \\2 \\2/p' | sed '/ __gnu_lto/d'\" lt_cv_sys_global_symbol_to_cdecl=\"\""

It could be refactored into something a bit cleaner without much work, probably a new make.conf.lto.defines entry like OVERRIDE_LIBTOOL or something. At least it would prevent it from running on every single package, as there are only a few that need it from what I've seen in the overlay.

[InBetweenNames]

Nevermind @nivedita76, your approach is better. I will integrate it into the overlay ASAP, but make it a conditional thing per package.

[nivedita76]

I think this is fixed with gcc 10 and binutils 2.34 so we don't need the hack.

https://sourceware.org/bugzilla/show_bug.cgi?id=25355

[kryptt]

I was also bitten by this with some packages failing... And I can confirm bumping up to binutils 2.34 worked