-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work #1
Conversation
@BigglesworthCat @SupperZum so.... the main app is done. Bot:
What should be done now:
|
@BigglesworthCat @SupperZum, I don't know, will you believe or not, but I got rid of every ))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design looks great! I like the way you used Rust ecosystem instruments from using logging and using thiserror
to event-based logic with tokio
, axum
and other crates.
Very cool👍.
But, for such large projects that require working with a third-party API, you should add a README.md with the requirements and necessary resources for customizing the bot yourself.
It would also be nice to see links to resources for using the API, such as connecting the bot to GitHub or how to get OpenAI token.
Also, it would be nice to run cargo clippy
to see certain irrational constructions that increase the code input, such as in match
constructions.
@BigglesworthCat should be better |
@BigglesworthCat @SupperZum I've added tests Should I add tests for |
@BigglesworthCat @SupperZum made all tests. Can you check please? Because I think I can ask for reviews very soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool project! I like this idea.
I have one point to note:
You have test data in the githost implementation. You have placed it directly in the source code, so it looks like it is necessary for the project. But actually, it is used only in tests. It is better to mark it is used only for testing (e.g. place them under the testdata
directory).
No description provided.