Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work #1

Merged
merged 27 commits into from
Oct 14, 2024
Merged

Work #1

merged 27 commits into from
Oct 14, 2024

Conversation

InAnYan
Copy link
Owner

@InAnYan InAnYan commented Aug 28, 2024

No description provided.

@InAnYan
Copy link
Owner Author

InAnYan commented Sep 24, 2024

@BigglesworthCat @SupperZum so.... the main app is done.

Bot:

  1. Writes messages to improve issues
  2. Labels issues automatically

What should be done now:

  1. Refactoring: get rid of dyn and `Arc<Mutex<..>>``
  2. Better logging?
  3. TESTING
  4. Write better prompts for LLM, but before doing this, the 5th task should be done
  5. Find a "real" repo to test the bot.

@InAnYan
Copy link
Owner Author

InAnYan commented Sep 25, 2024

@BigglesworthCat @SupperZum, I don't know, will you believe or not, but I got rid of every Arc<Mutex<...>> and dyn

)))

Copy link
Collaborator

@BigglesworthCat BigglesworthCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design looks great! I like the way you used Rust ecosystem instruments from using logging and using thiserror to event-based logic with tokio, axum and other crates.

Very cool👍.

But, for such large projects that require working with a third-party API, you should add a README.md with the requirements and necessary resources for customizing the bot yourself.
It would also be nice to see links to resources for using the API, such as connecting the bot to GitHub or how to get OpenAI token.

Also, it would be nice to run cargo clippy to see certain irrational constructions that increase the code input, such as in match constructions.

@InAnYan
Copy link
Owner Author

InAnYan commented Sep 29, 2024

@BigglesworthCat should be better

@InAnYan
Copy link
Owner Author

InAnYan commented Sep 30, 2024

@BigglesworthCat @SupperZum I've added tests

Should I add tests for OpenAiLlm and GithubHost?

@InAnYan
Copy link
Owner Author

InAnYan commented Sep 30, 2024

@BigglesworthCat @SupperZum made all tests. Can you check please?

Because I think I can ask for reviews very soon

Copy link

@niusia-ua niusia-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool project! I like this idea.

I have one point to note:
You have test data in the githost implementation. You have placed it directly in the source code, so it looks like it is necessary for the project. But actually, it is used only in tests. It is better to mark it is used only for testing (e.g. place them under the testdata directory).

@InAnYan InAnYan merged commit 893dc23 into main Oct 14, 2024
@InAnYan InAnYan deleted the work branch October 14, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants