break out s3 endpoint service into tag based calls for interface and …

[dennis-johnson-dev]

…gateway endpoints

Currently, when querying for a list of services to create VPC endpoints for, due to a recent change in AWS, we now get

"com.amazonaws.us-east-1.s3",
"com.amazonaws.us-east-1.s3",

back in the service name list which causes the data "aws_vpc_endpoint_service" data source to fail on finding duplicate items. The duplicate items comes from AWS creating endpoints for the s3 service for both interface and gateway types.

This approach requires manually tagging the VPC endpoints to work properly.

The consumers of this module don't require any updates to their interface or the list of services they are passing in. This module will break off the s3 service and handle it separately.

The long term approach is upgrading the AWS terraform provider to > 3.1 and utilizing the service_type terraform filter