Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add child dependency to parent dependencies. #325

Merged
merged 2 commits into from
Apr 29, 2019
Merged

Add child dependency to parent dependencies. #325

merged 2 commits into from
Apr 29, 2019

Conversation

hs-lsong
Copy link
Collaborator

Child dependency is also a parent dependency.

@hs-lsong hs-lsong requested a review from boulter April 29, 2019 19:38
@codecov-io
Copy link

codecov-io commented Apr 29, 2019

Codecov Report

Merging #325 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #325      +/-   ##
============================================
+ Coverage     71.38%   71.41%   +0.02%     
- Complexity     1569     1571       +2     
============================================
  Files           239      239              
  Lines          4921     4926       +5     
  Branches        794      796       +2     
============================================
+ Hits           3513     3518       +5     
  Misses         1124     1124              
  Partials        284      284
Impacted Files Coverage Δ Complexity Δ
...in/java/com/hubspot/jinjava/interpret/Context.java 80.32% <100%> (+0.55%) 85 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf9f77...3e998b9. Read the comment docs.

Copy link
Contributor

@boulter boulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need to clear those in Context.reset()

@hs-lsong hs-lsong requested a review from boulter April 29, 2019 20:49
@hs-lsong hs-lsong merged commit dadab06 into master Apr 29, 2019
@hs-lsong hs-lsong deleted the dependency branch April 29, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants