clear resolved things in global context after render #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
============================================
+ Coverage 71.42% 71.45% +0.03%
- Complexity 1374 1375 +1
============================================
Files 218 218
Lines 4343 4348 +5
Branches 689 689
============================================
+ Hits 3102 3107 +5
Misses 1000 1000
Partials 241 241
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
Jinjava.renderForResult, resolved variables, functions and expressions were added all the way up to the global context, but were never cleared. This created a memory leak where resolved expressions kept accumulating in these maps.Clear these transient values after each render.