-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename region_name to region_id and simplify CesClient interface #43
Conversation
9520631
to
9d6b565
Compare
any reason for this change? i actually prefer ces receiver, because it's the name of the service and there are other services for metrics in huawei. but, i'm fine if you want to change |
The reason for using the more generic name 'metrics' instead of 'ces' is to provide flexibility in the future. If we decide to replace CES with another service, the transition will be smoother without requiring additional changes to the receiver name. Additionally, the service name is clearly documented in the README, ensuring that there's no confusion about what which service is used. |
9d6b565
to
32fded8
Compare
hmm, in my o mind, CES wouldn't be replaced, since it's a established service. But, we would expand the number of huawei components to support other services, like AOM or APM. which also export metrics... but it's separate from CES |
621d9ff
to
3e46a22
Compare
got it. then we will keep the name of the receiver as it is. PTAL : this PR has been re-branded to something a bit different. |
3e46a22
to
f4c9389
Compare
f4c9389
to
e6ed3b7
Compare
No description provided.