Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename region_name to region_id and simplify CesClient interface #43

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

narcis96
Copy link

@narcis96 narcis96 commented Sep 4, 2024

No description provided.

@narcis96 narcis96 force-pushed the narcis/rename_metricsreceiver branch 5 times, most recently from 9520631 to 9d6b565 Compare September 4, 2024 08:04
@heitorganzeli
Copy link

any reason for this change? i actually prefer ces receiver, because it's the name of the service and there are other services for metrics in huawei.

but, i'm fine if you want to change

@narcis96
Copy link
Author

narcis96 commented Sep 4, 2024

any reason for this change? i actually prefer ces receiver, because it's the name of the service and there are other services for metrics in huawei.

but, i'm fine if you want to change

The reason for using the more generic name 'metrics' instead of 'ces' is to provide flexibility in the future. If we decide to replace CES with another service, the transition will be smoother without requiring additional changes to the receiver name. Additionally, the service name is clearly documented in the README, ensuring that there's no confusion about what which service is used.

@narcis96 narcis96 force-pushed the narcis/rename_metricsreceiver branch from 9d6b565 to 32fded8 Compare September 4, 2024 09:50
@heitorganzeli
Copy link

any reason for this change? i actually prefer ces receiver, because it's the name of the service and there are other services for metrics in huawei.
but, i'm fine if you want to change

The reason for using the more generic name 'metrics' instead of 'ces' is to provide flexibility in the future. If we decide to replace CES with another service, the transition will be smoother without requiring additional changes to the receiver name. Additionally, the service name is clearly documented in the README, ensuring that there's no confusion about what which service is used.

hmm, in my o mind, CES wouldn't be replaced, since it's a established service. But, we would expand the number of huawei components to support other services, like AOM or APM. which also export metrics... but it's separate from CES

@narcis96 narcis96 force-pushed the narcis/rename_metricsreceiver branch 2 times, most recently from 621d9ff to 3e46a22 Compare September 4, 2024 10:14
@narcis96 narcis96 changed the title rename huaweicloudcesreceiver to huaweicloudmetricsreceiver rename region_name to region_id and simplify CesClient interface Sep 4, 2024
@narcis96
Copy link
Author

narcis96 commented Sep 4, 2024

any reason for this change? i actually prefer ces receiver, because it's the name of the service and there are other services for metrics in huawei.
but, i'm fine if you want to change

The reason for using the more generic name 'metrics' instead of 'ces' is to provide flexibility in the future. If we decide to replace CES with another service, the transition will be smoother without requiring additional changes to the receiver name. Additionally, the service name is clearly documented in the README, ensuring that there's no confusion about what which service is used.

hmm, in my o mind, CES wouldn't be replaced, since it's a established service. But, we would expand the number of huawei components to support other services, like AOM or APM. which also export metrics... but it's separate from CES

got it. then we will keep the name of the receiver as it is.

PTAL : this PR has been re-branded to something a bit different.

@narcis96 narcis96 force-pushed the narcis/rename_metricsreceiver branch from 3e46a22 to f4c9389 Compare September 4, 2024 10:43
@narcis96 narcis96 force-pushed the narcis/rename_metricsreceiver branch from f4c9389 to e6ed3b7 Compare September 4, 2024 10:50
@heitorganzeli heitorganzeli merged commit c65e036 into main Sep 4, 2024
148 of 155 checks passed
@narcis96 narcis96 deleted the narcis/rename_metricsreceiver branch September 5, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants