fix(fullname): added extractFullName() template #2576
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/2VvkhAtyuarUVaPLnyiiWLB1CKNn |
|
|
|
Hi @jameszheng405 ! Thanks for this contribution. Have you previously signed our CLA? https://cla-assistant.io/HospitalRun/hospitalrun-frontend?pullRequest=2576 Also, it looks like your commits were not signed by an email tied to your Github account. If you need any guidance with sorting these issues out, let us know! |
Previously, the extractUserName() function was returning a mocked "some user." We scaffolded out this function for when we complete the user model. fix HospitalRun#2539 fixed extractFullName import remove reportedBy make app test less spurious
jameszheng405
force-pushed
the
reportedBy-bug2539
branch
from
d0d4c35 to
85414d5
Compare
| expect( | ||
| await screen.findByRole('heading', { name: /dashboard\.label/i }, { timeout: 8000 }), | ||
| ).toBeInTheDocument() | ||
| await waitFor(() => { |
There was a problem hiding this comment.
This test was failing, so we changed it to match RTL's default timeout behavior, and it now passes.
|
@morrme Can you review this PR again, I believe the tests are now passing |
matteovivona
added
the
in progress
fix #2539
Fixes #2539.
Changes proposed in this pull request:
Note: pull requests without proper descriptions may simply be closed without further discussion. We appreciate your contributions, but need to know what you are offering in clearly described format. Provide tests for all code that you add/modify. If you add/modify any components update the storybook. Thanks! (you can delete this text)