ripgrep: Install completions as rg.fish, etc.
#155680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripgrep v14 changed how shell completions are generated and in the switch to using `generate_completions_from_executable` we started writing completions to `ripgrep.fish` instead of `rg.fish`. This prevents the completions from being automatically loaded because the ripgrep executable is called `rg` not `ripgrep`.
github-actions
bot
added
the
rust
chenrui333
approved these changes
Nov 27, 2023
|
@cstyles also thanks for your first contribution to homebrew-core! 🎉 |
|
relates to #155592 |
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
would be captured in #155726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ripgrep v14 changed how shell completions are generated and in the switch to using
generate_completions_from_executablewe started writing completions toripgrep.fishinstead ofrg.fish. This prevents the completions from being automatically loaded because the ripgrep executable is calledrgnotripgrep.First time contributor here 👋. I'm not sure if a
revision 1is necessary so I'd appreciate some guidance on that.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?