Refactor return value of check_for_error to None for all servers #979

aleskxyz · 2023-10-30T14:59:53Z

check_for_error function returns None but some servers are expecting boolean.
I refactor all servers to check the return value explicitly is not None

Fix return value of check_for_error function to send false instead of None

HenriWahl · 2023-10-30T17:16:01Z

@aleskxyz thanks for the quick look for the cause, but in most cases the condition gets quite an opposite result now:

From

if errors_occured:

to

if errors_occured is not None:

there is an important difference, because in the first case it will only return if True, which extends to False in the second variant. I will have to check the consequences if done globally. Maybe as a fix it will be enough if done in Prometheus and Alertmanager.

aleskxyz · 2023-10-30T17:24:23Z

@aleskxyz thanks for the quick look for the cause, but in most cases the condition gets quite an opposite result now:

From
if errors_occured:
to
if errors_occured is not None:
there is an important difference, because in the first case it will only return if True, which extends to False in the second variant. I will have to check the consequences if done globally. Maybe as a fix it will be enough if done in Prometheus and Alertmanager.

@HenriWahl
I can use the first form but it seems we need to revert this PR also: #967

HenriWahl · 2023-10-30T17:40:39Z

OK, I will look for it tomorrow.

HenriWahl · 2023-10-31T17:21:43Z

@aleskxyz I checked it looks OK. Thanks for investigating!

HenriWahl · 2023-10-31T17:42:15Z

It's included now in latest release 3.13-20231031.

aleskxyz · 2023-11-01T12:48:28Z

@HenriWahl
You're welcome!
Maybe you need to check these lines. It seems that they don't store the output in any variable to check it later:

Nagstamon/Nagstamon/Servers/SnagView3.py

Line 193 in a9f40f5