-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the notificationIds body parameter for mark multiple notifs as read #14697
base: develop
Are you sure you want to change the base?
Conversation
This is made to solve issue HabitRPG#14484
@phillipthelen This PR looks good to me, but it also looks like it requires an update to the |
Is there any way i can help here? |
Ah, this... doesn't work. The API expects a body parameter, not a path parameter, so changing the API URL to a path parameter breaks the route entirely. And even if we did change the code to use a path instead of the request body, it'd be a breaking change to existing API consumers for little benefit. The source issue was simply that the body parameter wasn't documented, not that it needed to be in the path instead. See e.g. https://github.com/HabitRPG/habitica/blob/develop/website/server/controllers/api-v3/tasks.js#L59 -- something like that is all we need! |
@SabreCat Thanks for the feedback, I'll rectify my mistake and create another PR |
Is this how it was expected @SabreCat ?The changes i made are the highlighted lines in the image below: |
This is made to solve issue #14484
Fixes 14484
Changes
//: added the notificationIds parameter for mark multiple notifs as read
UUID:2db323ad-4e44-4446-aed2-6d3846e1682a